From bernhard at intevation.de  Thu Sep  5 16:36:20 2013
From: bernhard at intevation.de (Bernhard Reiter)
Date: Thu, 5 Sep 2013 16:36:20 +0200
Subject: SVN tag and tarball difference
Message-ID: <201309051636.27057.bernhard@intevation.de>

Hi Didrik,
hope you are doing fine.

Just noticed that there is a difference between the official 1.2.2 tarball
that you had created in 2009 and the svn tag.

In particular you've made a change that introduced a defect for the wms 
extension as far as I can see. And some of the wx2.8 port did not make it.

The patch to Extensions/wms/layer.py
-        foo = list(self.wmsserver.contents)                   
-        if len(foo) == 0:
+        layers = list(self.wmsserver.contents)                   
+        if len(layers) == 0:
             self.error_msg = _('No layers found in remote resource:\n'\
                                '%s') % url
             return
-        top_layer = foo[0]
+        top_layer = layers[1]

Some WMS services do not have a second layer, then Thuban will throw an 
exception here.

Another reason to release 1.2.3. :)
Best,
Bernhard

How to check:

mkdir probe
cd probe
LANG=C svn checkout \
  https://scm.wald.intevation.org/svn/thuban/tags/thuban-1-2-2-release \
  svn-tag-1-2-2

curl -k -O \ 
  https://wald.intevation.org/frs/download.php/620/Thuban-1.2.2.tar.bz2
curl -k -O \
  https://wald.intevation.org/frs/download.php/621/Thuban-1.2.2.tar.bz2.sig
gpg2 --verify Thuban-1.2.2.tar.bz2.sig

diff -ur diff -ur svn-tag-1-2-2/ Thuban-1.2.2 >x.diff


-- 
www.intevation.de/~bernhard (CEO)    www.fsfe.org (Founding GA Member)
Intevation GmbH, Osnabr?ck, Germany; Amtsgericht Osnabr?ck, HRB 18998
Owned and run by Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20130905/aea68573/attachment.bin