From crickett at gmail.com  Thu Oct 27 00:12:23 2005
From: crickett at gmail.com (Cave Crickett)
Date: Wed, 26 Oct 2005 16:12:23 -0600
Subject: [Mapit] PIL will not make map, BUG BUG!! Please make correction.
Message-ID: <6378d8d40510261512v4f93bb5eqc0aaf066ecaf10c4@mail.gmail.com>

Jan-Oliver Wagner & Mapit! mailing list,

There is a problem with the makemap.py file what is distributed on
ftp://intevation.de/mapit/mapit-1.0.2.tar.gz

line 78 reads:
image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFFFF)

should read:
image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFF)
There are too many F's.  This causes the PIL not to gen the map!

Please fix this bug in the source posted on the website.  This little
app looks nice and I would like others to be able to use it with out
the headache of finding this themselves!

--
Greg Bosen

Q:	What's tiny and yellow and very, very, dangerous?
A:	A canary with the super-user password



From bh at intevation.de  Thu Oct 27 17:20:54 2005
From: bh at intevation.de (Bernhard Herzog)
Date: Thu, 27 Oct 2005 17:20:54 +0200
Subject: [Mapit] PIL will not make map, BUG BUG!! Please make correction.
In-Reply-To: <6378d8d40510261512v4f93bb5eqc0aaf066ecaf10c4@mail.gmail.com>
	(Cave Crickett's message of "Wed, 26 Oct 2005 16:12:23 -0600")
References: <6378d8d40510261512v4f93bb5eqc0aaf066ecaf10c4@mail.gmail.com>
Message-ID: <s9zvezjnfzd.fsf@thetis.intevation.de>

Cave Crickett <crickett at gmail.com> writes:

> line 78 reads:
> image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFFFF)
>
> should read:
> image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFF)
> There are too many F's.  This causes the PIL not to gen the map!

Thanks for pointing this out!

Which Python version do you use?  What's the exact error message you
get?  I suspect it's Python 2.4.  In 2.4 the interpretation of
hexadecimal literals changed.  Formerly, on a 32 bit system, 0xFFFFFFFF
was -1, now it's 4294967295L.  With Python 2.4 I get the error

    return Image()._new(core.fill(mode, size, color))
SystemError: new style getargs format but argument is not a tuple

With older Python's the code that's in MapIt works just fine.  Of
course, since it doesn't work anymore with 2.4, we'll have to fix it.
Fixing it is easy enough.  The change you propose also works with older
Python+PIL versions including Python 1.5.2 and PIL 1.1.3.

I don't know when I'll have time to actually make a release, though.
Part of the difficulty there is that we don't really use mapit anymore
and haven't worked on it since April 2002.


   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/



From crickett at gmail.com  Thu Oct 27 17:38:31 2005
From: crickett at gmail.com (Cave Crickett)
Date: Thu, 27 Oct 2005 09:38:31 -0600
Subject: [Mapit] PIL will not make map, BUG BUG!! Please make correction.
In-Reply-To: <s9zvezjnfzd.fsf@thetis.intevation.de>
References: <6378d8d40510261512v4f93bb5eqc0aaf066ecaf10c4@mail.gmail.com>
	<s9zvezjnfzd.fsf@thetis.intevation.de>
Message-ID: <6378d8d40510270838k2e7b5ba5q925a48b5877220b5@mail.gmail.com>

I understand this isn't an active project.  A new release would be
nice, but at the least, a note on the installation page would have
saved me hours!

Thanks for a cool product.

G
PS. Are you looking for someone to take over this project?

My system:
=== OS/Kernel Version ===> uname -a
FreeBSD seisan.inel.gov 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Sun May  8
10:21:06 UTC 2005

=== python-2.4.1_3 ===> /var/db/pkg/python-2.4.1_3/+COMMENT
An interpreted object-oriented programming language

=== mod_python-2.7.11 ===> /var/db/pkg/mod_python-2.7.11/+COMMENT
Apache module for integrating Python

=== mod_fastcgi-2.4.2 ===> /var/db/pkg/mod_fastcgi-2.4.2/+COMMENT
A fast-cgi module for Apache

PIL 1.1.5

On 10/27/05, Bernhard Herzog <bh at intevation.de> wrote:
> Cave Crickett <crickett at gmail.com> writes:
>
> > line 78 reads:
> > image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFFFF)
> >
> > should read:
> > image = PIL.Image.new("RGB", (result_width, result_height), 0xFFFFFF)
> > There are too many F's.  This causes the PIL not to gen the map!
>
> Thanks for pointing this out!
>
> Which Python version do you use?  What's the exact error message you
> get?  I suspect it's Python 2.4.  In 2.4 the interpretation of
> hexadecimal literals changed.  Formerly, on a 32 bit system, 0xFFFFFFFF
> was -1, now it's 4294967295L.  With Python 2.4 I get the error
>
>     return Image()._new(core.fill(mode, size, color))
> SystemError: new style getargs format but argument is not a tuple
>
> With older Python's the code that's in MapIt works just fine.  Of
> course, since it doesn't work anymore with 2.4, we'll have to fix it.
> Fixing it is easy enough.  The change you propose also works with older
> Python+PIL versions including Python 1.5.2 and PIL 1.1.3.
>
> I don't know when I'll have time to actually make a release, though.
> Part of the difficulty there is that we don't really use mapit anymore
> and haven't worked on it since April 2002.
>
>
>    Bernhard
>
> --
> Intevation GmbH                                 http://intevation.de/
> Skencil                                           http://skencil.org/
> Thuban                                  http://thuban.intevation.org/
>


--
Greg Bosen

Q:	What's tiny and yellow and very, very, dangerous?
A:	A canary with the super-user password



From bernhard at intevation.de  Thu Oct 27 17:51:54 2005
From: bernhard at intevation.de (Bernhard Reiter)
Date: Thu, 27 Oct 2005 17:51:54 +0200
Subject: [Mapit] PIL will not make map, BUG BUG!! Please make correction.
In-Reply-To: <6378d8d40510270838k2e7b5ba5q925a48b5877220b5@mail.gmail.com>
References: <6378d8d40510261512v4f93bb5eqc0aaf066ecaf10c4@mail.gmail.com>
	<s9zvezjnfzd.fsf@thetis.intevation.de>
	<6378d8d40510270838k2e7b5ba5q925a48b5877220b5@mail.gmail.com>
Message-ID: <20051027155154.GD7232@intevation.de>

Am 27. Oct 2005 um 09:38:31 schrieb Cave Crickett:
> I understand this isn't an active project.  

We still use it in a few installations, 
but the UNM Mapserver just offers more features (though it is harder
to set up.)

> A new release would be
> nice, but at the least, a note on the installation page would have
> saved me hours!

Bernhard just made the change in the CVS.

> Thanks for a cool product.

You are welcome.

> G
> PS. Are you looking for someone to take over this project?

Yes, we indeed are.
Are you interested?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/mapit/attachments/20051027/a4228aba/attachment.bin